Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(category_theory/over/limits): change instance to def #3281

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(category_theory/over/limits): change instance to def #3281

wants to merge 1 commit into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Jul 3, 2020

Having this as an instance causes confusion since it's a different terminal object to the one inferred by the other limit constructions in the file.

@b-mehta b-mehta requested a review from semorrison July 3, 2020 13:16
@b-mehta b-mehta added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 3, 2020
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 5, 2020
bors bot pushed a commit that referenced this pull request Jul 5, 2020
@b-mehta
chore(category_theory/over/limits): change instance to def (#3281)
293287d 
Having this as an instance causes confusion since it's a different terminal object to the one inferred by the other limit constructions in the file.
@bors
Copy link

bors bot commented Jul 5, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory/over/limits): change instance to def [Merged by Bors] - chore(category_theory/over/limits): change instance to def Jul 5, 2020
@bors bors bot closed this Jul 5, 2020
@bors bors bot deleted the over-terminal branch July 5, 2020 10:40
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@b-mehta @cipher1024
chore(category_theory/over/limits): change instance to def (leanprove…
333dde4 
…r-community#3281)

Having this as an instance causes confusion since it's a different terminal object to the one inferred by the other limit constructions in the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@b-mehta @semorrison