Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs #3315

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs #3315

wants to merge 9 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Jul 8, 2020 •
edited

Blocked by #3312

@semorrison semorrison changed the title feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs (deps #3312) Jul 8, 2020
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 8, 2020
@semorrison semorrison mentioned this pull request Jul 8, 2020
Closed
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 8, 2020
@semorrison semorrison changed the title feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs (deps #3312) feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs Jul 8, 2020
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Jul 8, 2020
@jcommelin
Copy link
Member

looks good to me. feel free to merge after fixing the conflicts.

bors d+

@bors
Copy link

bors bot commented Jul 8, 2020

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 8, 2020
bors bot pushed a commit that referenced this pull request Jul 8, 2020
@semorrison @jcommelin
feat(category_theory/zero): lemmas about zero objects and zero morphi…
a3e21a8 
…sms, and improve docs (#3315)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jul 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs [Merged by Bors] - feat(category_theory/zero): lemmas about zero objects and zero morphisms, and improve docs Jul 8, 2020
@bors bors bot closed this Jul 8, 2020
@bors bors bot deleted the zero branch July 8, 2020 11:52
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@semorrison @jcommelin @cipher1024
feat(category_theory/zero): lemmas about zero objects and zero morphi…
9213622 
…sms, and improve docs (leanprover-community#3315)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @jcommelin