Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/univariate/qpf): compositional data type framework for (co)inductive types #3325

Closed
wants to merge 26 commits into from

Conversation

cipher1024
Copy link
Collaborator

@cipher1024 cipher1024 commented Jul 8, 2020

Define univariate QPFs (quotients of polynomial functors). This is the first part of #3317.


@robertylewis
Copy link
Member

I've barely glanced at this, but I recall @avigad added W-types in #1817 and I saw a definition of W here. Is this duplicated or is the context sufficiently different?

@cipher1024
Copy link
Collaborator Author

The definition itself is similar. We format the arguments differently because we it as part of an F-algebra. I can't see any function that we have in common. Sharing the definition of W-type seems like it would just add boilerplate

Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module doc strings still need to be added everywhere.

src/data/qpf/univariate/pfunctor/M.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/pfunctor/basic.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/pfunctor/basic.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/pfunctor/basic.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/pfunctor/basic.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/qpf.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/qpf.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/qpf.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/qpf.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/qpf.lean Outdated Show resolved Hide resolved
@cipher1024 cipher1024 requested a review from gebner July 9, 2020 23:19
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining stylistic issues aside, this looks good to me.

src/data/qpf/univariate/qpf.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/pfunctor/M.lean Outdated Show resolved Hide resolved
src/data/quot.lean Outdated Show resolved Hide resolved
src/data/quot.lean Outdated Show resolved Hide resolved
src/data/qpf/univariate/pfunctor/M.lean Outdated Show resolved Hide resolved
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
cipher1024 and others added 3 commits July 10, 2020 09:39
@cipher1024
Copy link
Collaborator Author

I wonder if I should move data.qpf.univariate.pfunctor to data.pfunctor.univariate

@gebner
Copy link
Member

gebner commented Jul 10, 2020

I wonder if I should move data.qpf.univariate.pfunctor to data.pfunctor.univariate

That's a good idea.

@gebner
Copy link
Member

gebner commented Jul 10, 2020

bors r+

bors bot pushed a commit that referenced this pull request Jul 10, 2020
…inductive types (#3325)

Define univariate QPFs (quotients of polynomial functors).  This is the first part of #3317.
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 10, 2020
@bors
Copy link

bors bot commented Jul 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/univariate/qpf): compositional data type framework for (co)inductive types [Merged by Bors] - feat(data/univariate/qpf): compositional data type framework for (co)inductive types Jul 10, 2020
@bors bors bot closed this Jul 10, 2020
@bors bors bot deleted the qpf-univariate branch July 10, 2020 19:01
cipher1024 added a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…inductive types (leanprover-community#3325)

Define univariate QPFs (quotients of polynomial functors).  This is the first part of leanprover-community#3317.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants