Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/matrix): add matrix.map and supporting lemmas #3352

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(data/matrix): add matrix.map and supporting lemmas #3352

wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

As requested.

@semorrison semorrison mentioned this pull request Jul 10, 2020
Closed
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Jul 10, 2020
jcommelin
jcommelin approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 10, 2020
bors bot pushed a commit that referenced this pull request Jul 10, 2020
@semorrison
feat(data/matrix): add matrix.map and supporting lemmas (#3352)
a4509bd 
As [requested](https://github.com/leanprover-community/mathlib/pull/3276/files#r452366674).



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bryangingechen
Copy link
Collaborator

linting failed ☹️
bors r-

@bors
Copy link

bors bot commented Jul 10, 2020

Canceled.

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 10, 2020
@semorrison @bryangingechen
Apply suggestions from code review
bff2461 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 10, 2020
bors bot pushed a commit that referenced this pull request Jul 10, 2020
@semorrison
feat(data/matrix): add matrix.map and supporting lemmas (#3352)
bcf733f 
As [requested](https://github.com/leanprover-community/mathlib/pull/3276/files#r452366674).



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/matrix): add matrix.map and supporting lemmas [Merged by Bors] - feat(data/matrix): add matrix.map and supporting lemmas Jul 10, 2020
@bors bors bot closed this Jul 10, 2020
@bors bors bot deleted the matrix_map branch July 10, 2020 06:31
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@semorrison @cipher1024
feat(data/matrix): add matrix.map and supporting lemmas (leanprover-c…
c8cfc5d 
…ommunity#3352)

As [requested](https://github.com/leanprover-community/mathlib/pull/3276/files#r452366674).



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @bryangingechen @jcommelin