Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/affine_space): more lemmas on directions of affine subspaces #3377

Closed
wants to merge 4 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Jul 12, 2020

Add more lemmas on directions of affine subspaces, motivated by uses
for Euclidean geometry.


…e subspaces

Add more lemmas on directions of affine subspaces, motivated by uses
for Euclidean geometry.
@jsm28 jsm28 added the awaiting-review The author would like community review of the PR label Jul 12, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good!

src/linear_algebra/affine_space.lean Outdated Show resolved Hide resolved
src/linear_algebra/affine_space.lean Outdated Show resolved Hide resolved
jsm28 and others added 3 commits July 13, 2020 19:54
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 13, 2020
bors bot pushed a commit that referenced this pull request Jul 13, 2020
…e subspaces (#3377)

Add more lemmas on directions of affine subspaces, motivated by uses
for Euclidean geometry.
@bors
Copy link

bors bot commented Jul 13, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/affine_space): more lemmas on directions of affine subspaces [Merged by Bors] - feat(linear_algebra/affine_space): more lemmas on directions of affine subspaces Jul 13, 2020
@bors bors bot closed this Jul 13, 2020
@bors bors bot deleted the affine-subspace-direction-lemmas branch July 13, 2020 21:30
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…e subspaces (leanprover-community#3377)

Add more lemmas on directions of affine subspaces, motivated by uses
for Euclidean geometry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants