Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/algebra/continuous_functions): algebra structure over continuous functions #3383

Closed
wants to merge 17 commits into from

Conversation

Nicknamen
Copy link
Collaborator


We proved topological-algebra-valued continuous functions have an algebra structure.

@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Jul 13, 2020
@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jul 13, 2020
@Nicknamen Nicknamen changed the title feat(topology/algebra/continuous_functions): Algebra structure over continuous functions feat(topology/algebra/continuous_functions): algebra structure over continuous functions Jul 13, 2020
@semorrison
Copy link
Collaborator

Sorry it's taken a while for anyone to look at this --- the workshop on this week has been very distracting.

@semorrison
Copy link
Collaborator

These comments are only a superficial look; hopefully I'll be able to come back to this soon, or someone else will.

I wonder how hard just finishing off subsemiring will be. It would be good to get this mammoth refactor behind us. :-)

Nicknamen and others added 5 commits July 18, 2020 13:39
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@Nicknamen
Copy link
Collaborator Author

In any case, I just copied the proofs of continuous functions being a group or a ring to also prove they are a module and an algebra! I am not sure many reviews are needed for this, but I added @PatrickMassot so that he can have a look as well! If he thinks this PR is ready to merge and we can merge it, I have a lot of other PRs in cue that I want to push, like the one has_continuous_mul

@semorrison
Copy link
Collaborator

I think this is fine. We'll let you get on with the other PRs. :-)

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 19, 2020
bors bot pushed a commit that referenced this pull request Jul 19, 2020
@bors
Copy link

bors bot commented Jul 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/algebra/continuous_functions): algebra structure over continuous functions [Merged by Bors] - feat(topology/algebra/continuous_functions): algebra structure over continuous functions Jul 19, 2020
@bors bors bot closed this Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants