Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/digits): add lemmas about digits #3406

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(data/nat/digits): add lemmas about digits #3406

wants to merge 4 commits into from

Conversation

shingtaklam1324
Copy link
Collaborator

@shingtaklam1324 shingtaklam1324 commented Jul 15, 2020 •
edited

Added lt_base_pow_length_digits, of_digits_lt_base_pow_length, of_digits_append and of_digits_digits_append_digits

  • I'm still not 100% sure on what arguments should be explicit vs implicit, so comments about that are welcome
  • also, I put the lemmas right after all the required declarations, if I should group them as well as other lemmas I'd be happy to do so.

jcommelin
jcommelin reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

src/data/nat/digits.lean Outdated Show resolved Hide resolved
@shingtaklam1324 @jcommelin
Update src/data/nat/digits.lean - remove extra whitespace
0b17c43 
Co-authored-by: Johan Commelin <johan@commelin.net>
@shingtaklam1324 shingtaklam1324 added the awaiting-review The author would like community review of the PR label Jul 15, 2020
@ChrisHughes24
Copy link
Member

The only change I would make to this is to replace len in all the names with length. After that it's ready to merge.

@shingtaklam1324
Copy link
Collaborator Author

Done. The len in the lemma names have been replaced by length.

@bryangingechen
Copy link
Collaborator

Thank you!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 16, 2020
bors bot pushed a commit that referenced this pull request Jul 16, 2020
@shingtaklam1324
feat(data/nat/digits): add lemmas about digits (#3406)
25be04a 
Added `lt_base_pow_length_digits`, `of_digits_lt_base_pow_length`, `of_digits_append` and `of_digits_digits_append_digits`
@bors
Copy link

bors bot commented Jul 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/digits): add lemmas about digits [Merged by Bors] - feat(data/nat/digits): add lemmas about digits Jul 16, 2020
@bors bors bot closed this Jul 16, 2020
@bors bors bot deleted the digit_lemmas branch July 16, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shingtaklam1324 @ChrisHughes24 @bryangingechen @jcommelin