Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(order/filter/basic): add class filter.ne_bot #3454

Closed
wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 19, 2020

This way Lean will f≠ ⊥ in a few most common cases
(incl. nhds_ne_bot, at_top_ne_bot) automatically.

Other API changes:

  • many lemmas now take [ne_bot l] instead of (hl : l ≠ ⊥);
  • some lemmas got ' versions that take an explicit (hl : ne_bot l);
  • rename ultrafilter_unique to is_ultrafilter.unique;
  • cauchy_downwards is now cauchy.mono (instance arg) and cauchy.mono' (explicit arg);
  • cauchy_map is now cauchy.map;
  • cauchy_comap is now cauchy.comap;
  • totally_bounded_closure is now totally_bounded.closure;
  • totally_bounded_image is now totally_bounded.image;

This way Lean will find a few most common `≠ ⊥` arguments
(incl. `nhds_ne_bot`, `at_top_ne_bot`) automatically.
@urkud urkud added the awaiting-review The author would like community review of the PR label Jul 19, 2020
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wanted a smaller refactor to relax after the integrals refactor? :-) Thanks for doing this, this is great. I just have two minor comments.

bors d+

src/order/liminf_limsup.lean Outdated Show resolved Hide resolved
src/topology/algebra/ordered.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 19, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
Copy link
Member Author

urkud commented Jul 19, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 19, 2020
@bryangingechen
Copy link
Collaborator

I wonder why this isn't batched with #3444. Going to see if I can batch them by hand.
bors r-

@bryangingechen
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Jul 19, 2020
This way Lean will f`≠ ⊥` in a few most common cases
(incl. `nhds_ne_bot`, `at_top_ne_bot`) automatically.

Other API changes:

* many lemmas now take `[ne_bot l]` instead of `(hl : l ≠ ⊥)`;
* some lemmas got `'` versions that take an explicit `(hl : ne_bot l)`;
* rename `ultrafilter_unique` to `is_ultrafilter.unique`;
* `cauchy_downwards` is now `cauchy.mono` (instance arg) and `cauchy.mono'` (explicit arg);
* `cauchy_map` is now `cauchy.map`;
* `cauchy_comap` is now `cauchy.comap`;
* `totally_bounded_closure` is now `totally_bounded.closure`;
* `totally_bounded_image` is now `totally_bounded.image`;
@bors
Copy link

bors bot commented Jul 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(order/filter/basic): add class filter.ne_bot [Merged by Bors] - refactor(order/filter/basic): add class filter.ne_bot Jul 19, 2020
@bors bors bot closed this Jul 19, 2020
@bors bors bot deleted the ne-bot-class branch July 19, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants