feat(tactic/ext): add apply_cfg argument to ext1 #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes goals to appear in the same order they appear as hypotheses of the
@[extensionality]
lemma, rather than being reordered to put dependentgoals first.
This doesn't appear to affect any uses of
ext
in mathlib,but is occasionally helpful in the development of category theory.
(Indeed, I have been running into tactic mode proofs that fail to
typecheck, when using ext, and this avoids the problem. My
actual dependent ext lemma is at here, and the place where I need
to swap the goals back into order by hand is here.)
TO CONTRIBUTORS:
Make sure you have:
For reviewers: code review check list