Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(group_theory/perm): sign_cycle and sign_bij #347

Merged
merged 8 commits into from
Sep 19, 2018
Merged

feat(group_theory/perm): sign_cycle and sign_bij #347

merged 8 commits into from
Sep 19, 2018

Conversation

ChrisHughes24
Copy link
Member

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

digama0
digama0 reviewed Sep 13, 2018
View reviewed changes
algebra/group_power.lean Outdated Show resolved Hide resolved
@ChrisHughes24 ChrisHughes24 changed the title feat(group_theory/perm): sign_cycle and sign_eq_sign_of_injective feat(group_theory/perm): sign_cycle and sign_bij Sep 13, 2018
johoelzl
johoelzl reviewed Sep 17, 2018
View reviewed changes
Copy link
Collaborator

@johoelzl johoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the topic very well, but it looks good to me.

Just some nitpicking about indentation and generalizing some proofs.

group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
group_theory/perm.lean Outdated Show resolved Hide resolved
@johoelzl johoelzl merged commit 318ec36 into leanprover-community:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

@johoelzl johoelzl johoelzl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @digama0 @johoelzl