-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(topology): more lemmas about Ici and Iic neighborhoods #3474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADedecker
added
the
awaiting-review
The author would like community review of the PR
label
Jul 20, 2020
urkud
reviewed
Jul 21, 2020
LGTM. While you're at it, could you please add instances |
bors d+ |
✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Jul 21, 2020
bryangingechen
changed the title
feat(topology) : more lemmas about Ici and Iic neighborhoods
feat(topology): more lemmas about Ici and Iic neighborhoods
Jul 21, 2020
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 21, 2020
Main feature : add `tfae_mem_nhds_within_Ici` and `tfae_mem_nhds_within_Iic`, analogous to the existing `tfae_mem_nhds_within_Ioi` and `tfae_mem_nhds_within_Iio`, as well as related lemmas (again imitating the open case) I also added a few lemmas in `data/set/intervals/basic.lean` that were useful for this and a few upcoming PRs Co-authored-by: Anatole Dedecker <48656793+ADedecker@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(topology): more lemmas about Ici and Iic neighborhoods
[Merged by Bors] - feat(topology): more lemmas about Ici and Iic neighborhoods
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main feature : add
tfae_mem_nhds_within_Ici
andtfae_mem_nhds_within_Iic
, analogous to the existingtfae_mem_nhds_within_Ioi
andtfae_mem_nhds_within_Iio
, as well as related lemmas (again imitating the open case)I also added a few lemmas in
data/set/intervals/basic.lean
that were useful for this and a few upcoming PRsThis does also contains preliminaries for L'Hopital's rule, although this only apply to a small part of the PR