Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology): more lemmas about Ici and Iic neighborhoods #3474

Closed
wants to merge 4 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Jul 20, 2020

Main feature : add tfae_mem_nhds_within_Ici and tfae_mem_nhds_within_Iic, analogous to the existing tfae_mem_nhds_within_Ioi and tfae_mem_nhds_within_Iio, as well as related lemmas (again imitating the open case)

I also added a few lemmas in data/set/intervals/basic.lean that were useful for this and a few upcoming PRs


This does also contains preliminaries for L'Hopital's rule, although this only apply to a small part of the PR

@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Jul 20, 2020
@urkud
Copy link
Member

urkud commented Jul 21, 2020

LGTM. While you're at it, could you please add instances nhds_within_Ici_self_ne_bot and nhds_within_Iic_self_ne_bot?

@urkud
Copy link
Member

urkud commented Jul 21, 2020

bors d+

@bors
Copy link

bors bot commented Jul 21, 2020

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 21, 2020
@bryangingechen bryangingechen changed the title feat(topology) : more lemmas about Ici and Iic neighborhoods feat(topology): more lemmas about Ici and Iic neighborhoods Jul 21, 2020
ADedecker and others added 2 commits July 21, 2020 14:27
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@ADedecker
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 21, 2020
Main feature :  add `tfae_mem_nhds_within_Ici` and `tfae_mem_nhds_within_Iic`, analogous to the existing `tfae_mem_nhds_within_Ioi` and `tfae_mem_nhds_within_Iio`, as well as related lemmas (again imitating the open case)

I also added a few lemmas in `data/set/intervals/basic.lean` that were useful for this and a few upcoming PRs



Co-authored-by: Anatole Dedecker <48656793+ADedecker@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 21, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology): more lemmas about Ici and Iic neighborhoods [Merged by Bors] - feat(topology): more lemmas about Ici and Iic neighborhoods Jul 21, 2020
@bors bors bot closed this Jul 21, 2020
@bors bors bot deleted the nhds_within_Iic_Ici branch July 21, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants