Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/convex/basic): add lemmas about convex combination of endpoints of intervals #3482

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(analysis/convex/basic): add lemmas about convex combination of endpoints of intervals #3482

wants to merge 7 commits into from

Conversation

dupuisf
Copy link
Collaborator

@dupuisf dupuisf commented Jul 20, 2020

Some lemmas that state that if x ∈ Ioo a b, then x can be expressed as a convex combination of a and b (and similar lemmas for Ico, Ioc and Icc). This is needed for an upcoming PR of a proof that a local minimum of a convex function is a global minimum.

@dupuisf dupuisf added awaiting-review The author would like community review of the PR not-ready-to-merge and removed awaiting-review The author would like community review of the PR labels Jul 20, 2020
@dupuisf dupuisf added awaiting-review The author would like community review of the PR and removed not-ready-to-merge labels Jul 21, 2020
@semorrison
Copy link
Collaborator

I noticed that the proofs work verbatim if you replace ℝ with ℚ in the statements. Can you identify the correct minimal assumption in the form of a typeclass, and generalise to that?

@semorrison
Copy link
Collaborator

Otherwise, looks great!

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 21, 2020
@dupuisf dupuisf added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 22, 2020
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 22, 2020
@dupuisf dupuisf added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 22, 2020
dupuisf and others added 2 commits July 22, 2020 10:16
@dupuisf @bryangingechen
Update src/analysis/convex/basic.lean
31b4491 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@dupuisf
add spaces between tactics and arguments
803d2df
robertylewis
robertylewis reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this file isn't slower than it is!

src/analysis/convex/basic.lean Outdated Show resolved Hide resolved
@dupuisf @robertylewis
calc blocks -> field_simp
c053222 
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
@semorrison
Copy link
Collaborator

Looks great, thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 23, 2020
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Jul 23, 2020
bors bot pushed a commit that referenced this pull request Jul 23, 2020
@dupuisf
feat(analysis/convex/basic): add lemmas about convex combination of e…
827fcd0 
…ndpoints of intervals (#3482)

Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 23, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/convex/basic): add lemmas about convex combination of endpoints of intervals [Merged by Bors] - feat(analysis/convex/basic): add lemmas about convex combination of endpoints of intervals Jul 23, 2020
@bors bors bot closed this Jul 23, 2020
@bors bors bot deleted the convex_combo branch July 23, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@robertylewis robertylewis robertylewis left review comments

@bryangingechen bryangingechen bryangingechen left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dupuisf @semorrison @robertylewis @bryangingechen