[Merged by Bors] - chore(algebraic_geometry/presheafed_space): use projection rather than fancy coercion #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
blocked-by-other-PR
bryangingechen
added
awaiting-review
bryangingechen
changed the title
|
I don't know anything about this but it looks innocuous enough and I trust Scott's judgment here. If nobody else chimes in in a bit I'll merge. @jcommelin @rwbarton is this one of your areas? |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2020
…n fancy coercion (#3507) We'd gone to great effort when writing `PresheafedSpace` to create a coercion from morphisms of `PresheafedSpace`s to morphisms in `Top`. It's hard to read, it's fragile. So this PR rips out that coercion, and renames the "continuous map between base spaces" field from `f` to `base`, and uses that throughout. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd gone to great effort when writing
PresheafedSpaceto create a coercion from morphisms ofPresheafedSpaces to morphisms inTop.It's hard to read, it's fragile.
So this PR rips out that coercion, and renames the "continuous map between base spaces" field from
ftobase, and uses that throughout.Blocked on #3506, don't bother reviewing until that's settled.