Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): explicit isomorphisms between preserved limits #3602

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits): explicit isomorphisms between preserved limits #3602

wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

When G preserves limits, it's nice to be able to quickly obtain the iso G.obj (pi_obj f) ≅ pi_obj (λ j, G.obj (f j)).

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Jul 28, 2020
@semorrison semorrison mentioned this pull request Jul 28, 2020
Closed
fpvandoorn
fpvandoorn reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much do we care about nonterminal dsimp? I tend to avoid them, but I'm not sure how feasible that is in the category theory library.

src/category_theory/limits/preserves/shapes.lean Outdated Show resolved Hide resolved
src/category_theory/limits/preserves/shapes.lean Show resolved Hide resolved
src/category_theory/limits/preserves/shapes.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator Author

How much do we care about nonterminal dsimp? I tend to avoid them, but I'm not sure how feasible that is in the category theory library.

I've added a See note [dsimp, simp].

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 10, 2020
bors bot pushed a commit that referenced this pull request Aug 10, 2020
@semorrison
feat(category_theory/limits): explicit isomorphisms between preserved…
4786136 
… limits (#3602)

When `G` preserves limits, it's nice to be able to quickly obtain the iso `G.obj (pi_obj f) ≅ pi_obj (λ j, G.obj (f j))`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@fpvandoorn
Copy link
Member

The note dsimp, simp is indeed helpful. I expected that something like that was going on. In that case the nonterminal dsimps make sense.

@bors
Copy link

bors bot commented Aug 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): explicit isomorphisms between preserved limits [Merged by Bors] - feat(category_theory/limits): explicit isomorphisms between preserved limits Aug 10, 2020
@bors bors bot closed this Aug 10, 2020
@bors bors bot deleted the preserves_limits_isos branch August 10, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @fpvandoorn