Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology): assorted topological lemmas #3619

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(topology): assorted topological lemmas #3619

wants to merge 2 commits into from

Conversation

PatrickMassot
Copy link
Member

from the sphere eversion project

@PatrickMassot
feat(topology): assorted topological lemmas
5f04979 
from the sphere eversion project
@PatrickMassot PatrickMassot added the awaiting-review The author would like community review of the PR label Jul 28, 2020
@urkud
Copy link
Member

urkud commented Jul 28, 2020 •
edited

I'm going to golf a few proofs. UPD: done. Please have a look at filter.has_basis.restrict.

@PatrickMassot
Copy link
Member Author

Nice ! Do we need a third maintainer now?

jcommelin
jcommelin reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 29, 2020
bors bot pushed a commit that referenced this pull request Jul 29, 2020
@PatrickMassot @urkud
feat(topology): assorted topological lemmas (#3619)
80f2762 
from the sphere eversion project



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jul 29, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology): assorted topological lemmas [Merged by Bors] - feat(topology): assorted topological lemmas Jul 29, 2020
@bors bors bot closed this Jul 29, 2020
@bors bors bot deleted the random_lemmas branch July 29, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PatrickMassot @urkud @jcommelin