New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(geometry/manifold): smooth bundled maps #3641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good to me, I just have minor comments (but a fair number of them :)
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
bors r+ |
@sgouezel Sorry, I had one requested change that I don't think was resolved, is there any way to pause bors (or perhaps @Nicknamen or I could do a follow-up PR just for that)? |
@hrmacbeth yes sorry for this we agreed to do it in a next PR because this was too big, I should have tagged you in the message. In fact I will include it in the PR on GL(n), which is my last PR. Do you need it before for your work? |
Thanks, that sounds great! No, I don't need it for anything. Sorry I missed the earlier discussion. |
If you want to cancel a merge, you can do |
Pull request successfully merged into master. Build succeeded: |
We mainly prove field valued smooth maps are an algebra over the field. We also prove intermediate results and we introduce smooth monoids (examples of which are the interval [0,1], nonnegative real numbers, some closed subgroup of matrices groups...).