Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/set/intervals): define set.ord_connected #3647

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 31, 2020

A set s : set α, [preorder α] is ord_connected if for
any x y ∈ s we have [x, y] ⊆ s. For real numbers this property
is equivalent to each of the properties convex s
and is_preconnected s. We define it for any preorder, prove some
basic properties, and migrate lemmas like convex_I?? and
is_preconnected_I?? to this API.


Started as a part of #3640

A set `s : set α`, `[preorder α]` is `ord_connected` if for
any `x y ∈ s` we have `[x, y] ⊆ s`. For real numbers this property
is equivalent to each of the properties `convex s`
and `is_preconnected s`. We define it for any `preorder`, prove some
basic properties, and migrate lemmas like `convex_I??` and
`is_preconnected_I??` to this API.
@urkud urkud added the awaiting-review The author would like community review of the PR label Jul 31, 2020
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 1, 2020
src/data/set/intervals/ord_connected.lean Outdated Show resolved Hide resolved
src/data/set/intervals/ord_connected.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 1, 2020
src/data/set/intervals/ord_connected.lean Outdated Show resolved Hide resolved
src/data/set/intervals/ord_connected.lean Outdated Show resolved Hide resolved
@sgouezel
Copy link
Collaborator

sgouezel commented Aug 2, 2020

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 2, 2020
bors bot pushed a commit that referenced this pull request Aug 2, 2020
A set `s : set α`, `[preorder α]` is `ord_connected` if for
any `x y ∈ s` we have `[x, y] ⊆ s`. For real numbers this property
is equivalent to each of the properties `convex s`
and `is_preconnected s`. We define it for any `preorder`, prove some
basic properties, and migrate lemmas like `convex_I??` and
`is_preconnected_I??` to this API.



Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@bors
Copy link

bors bot commented Aug 2, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 2, 2020
A set `s : set α`, `[preorder α]` is `ord_connected` if for
any `x y ∈ s` we have `[x, y] ⊆ s`. For real numbers this property
is equivalent to each of the properties `convex s`
and `is_preconnected s`. We define it for any `preorder`, prove some
basic properties, and migrate lemmas like `convex_I??` and
`is_preconnected_I??` to this API.



Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@bors
Copy link

bors bot commented Aug 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/intervals): define set.ord_connected [Merged by Bors] - feat(data/set/intervals): define set.ord_connected Aug 2, 2020
@bors bors bot closed this Aug 2, 2020
@bors bors bot deleted the ord_connected branch August 2, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants