[Merged by Bors] - feat(measure_theory): cleanup and generalize measure' #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caratheodory_is_measurable -> of_function_caratheodory make the section on caratheodory sets not private generalize more statements about induced_outer_measure
fpvandoorn
added
the
awaiting-review
|
I'm sorry that the diff is not very useful, since I moved lemmas in the process. Perhaps it's helpful to see the diffs before the move: |
urkud
reviewed
Aug 1, 2020
urkud
reviewed
Aug 1, 2020
urkud
reviewed
Aug 1, 2020
also add nolint inhabited for equiv
urkud
reviewed
Aug 1, 2020
|
LGTM modulo 1 comment |
|
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2020
There were two functions `measure'` and `outer_measure'` with undescriptive names, and which were not very general rename `measure'` -> `extend` rename `outer_measure'` -> `induced_outer_measure` generalize both `extend` and `induced_outer_measure` to an arbitrary subset of `set α` (instead of just the measurable sets). Most lemmas still hold in full generality, sometimes with a couple more assumptions. For the lemmas that need more assumptions, we have also kept the version that is just for `is_measurable`. Move functions `extend`, `induced_outer_measure` and `trim` to `outer_measure.lean`. rename `caratheodory_is_measurable` -> `of_function_caratheodory` rename `trim_ge` -> `le_trim` Make the section on caratheodory sets not private (and give a more descriptive name to lemmas). Style in `measurable_space` and `outer_measure`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two functions
measure'andouter_measure'with undescriptive names, and which were not very generalrename
measure'->extendrename
outer_measure'->induced_outer_measuregeneralize both
extendandinduced_outer_measureto an arbitrary subset ofset α(instead of just the measurable sets). Most lemmas still hold in full generality, sometimes with a couple more assumptions. For the lemmas that need more assumptions, we have also kept the version that is just foris_measurable.Move functions
extend,induced_outer_measureandtrimtoouter_measure.lean.rename
caratheodory_is_measurable->of_function_caratheodoryrename
trim_ge->le_trimMake the section on caratheodory sets not private (and give a more descriptive name to lemmas).
Style in
measurable_spaceandouter_measureThe changes in
measurable_spaceare almost exclusively style changes.