[Merged by Bors] - feat(order/filter/interval): define class filter.is_interval_generated
#3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
the
blocked-by-other-PR
| A filter `f` on a `preorder` is interval generated if each set `s ∈ f` includes an `ord_connected` | ||
| subset `t ∈ f`. | ||
| -/ | ||
| class is_interval_generated (f : filter α) : Prop := |
There was a problem hiding this comment.
Would it be more consistent and efficient to also make ord_connected a class?
There was a problem hiding this comment.
It has conversions to/from convex and is_preconnected. Another difficulty is that some lemmas (e.g., ord_connected_sUnion) have non-instance arguments. Possibly I can make it a @[class] def but I'd prefer not to do it right now.
urkud
changed the title
filter.is_interval_generated deps: 3618filter.is_interval_generated
urkud
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
filter.is_interval_generatedfilter.is_interval_generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another chunk of #3640,
depends on #3618