[Merged by Bors] - chore(algebra/group_ring_action): docstring, move monoid.End to algebra/group/hom #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kckennylau
commented
Aug 3, 2020
•
kckennylau
commented
kckennylau
changed the title
urkud
reviewed
Aug 3, 2020
| # Group action on rings | ||
|
|
||
| This file defines the typeclass of monoid acting on semirings `mul_semiring_action M R`, | ||
| and the corresponding typeclass of invariant subrings. |
There was a problem hiding this comment.
Please mention that algebra does not satisfy axioms of mul_semiring_action.
src/algebra/group/hom.lean
Outdated
| one_mul := monoid_hom.id_comp } | ||
|
|
||
| instance monoid.End.inhabited : inhabited (monoid.End M) := | ||
| ⟨1⟩ |
There was a problem hiding this comment.
Could you please define has_coe_to_fun and add lemmas coe_one : ((1 : monoid.End M) : M → M) = id and coe_mul : ((f * g : monoid.End M) : M → M) = f ∘ g in monoid and add_monoid namespaces?
urkud
added
the
awaiting-author
kckennylau
added
the
awaiting-review
urkud
removed
the
awaiting-author
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.