Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measurable_space): more properties of measurable sets in a product #3703

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(measurable_space): more properties of measurable sets in a product #3703

wants to merge 5 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Aug 6, 2020 •
edited

Add multiple lemmas about prod to set.basic
Some cleanup in set.basic
Fix the name of the instance measure_space ℝ
Cleanup and a couple of additions to the prod section of measurable_space.
Rename: prod_singleton_singleton -> singleton_prod_singleton
Use prod.swap in the statement of image_swap_prod.

@fpvandoorn fpvandoorn added the awaiting-review The author would like community review of the PR label Aug 6, 2020
urkud
urkud reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/data/set/basic.lean Outdated Show resolved Hide resolved
src/data/set/basic.lean Outdated Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 6, 2020
@fpvandoorn
more cleanup:
09f31a7 
remove nonterminal simps
add more lemmas about prod
use projection notation for set.prod
@fpvandoorn
fix set/lattice
3736cfd
@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 6, 2020
@urkud
Copy link
Member

urkud commented Aug 7, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 7, 2020
bors bot pushed a commit that referenced this pull request Aug 7, 2020
@fpvandoorn
feat(measurable_space): more properties of measurable sets in a produ…
aacd757 
…ct (#3703)

Add multiple lemmas about `prod` to `set.basic`
Some cleanup in `set.basic`
Fix the name of the instance `measure_space ℝ`
Cleanup and a couple of additions to the `prod` section of `measurable_space`.
Rename: `prod_singleton_singleton` -> `singleton_prod_singleton`
Use `prod.swap` in the statement of `image_swap_prod`.
@bors
Copy link

bors bot commented Aug 7, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measurable_space): more properties of measurable sets in a product [Merged by Bors] - feat(measurable_space): more properties of measurable sets in a product Aug 7, 2020
@bors bors bot closed this Aug 7, 2020
@bors bors bot deleted the measurable-prod branch August 7, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpvandoorn @urkud @robertylewis