[Merged by Bors] - chore(*): swap order of [fintype A] [decidable_eq A] #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Almost forgot: |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
@fpvandoorn suggested in #3603 swapping the order of some `[fintype A] [decidable_eq A]` arguments to solve a linter problem with slow typeclass lookup. The reasoning is that Lean solves typeclass search problems from right to left, and * it's "less likely" that a type is a `fintype` than it has `decidable_eq`, so we can fail earlier if `fintype` comes second * typeclass search for `[decidable_eq]` can already be slow, so it's better to avoid it. This PR applies this suggestion across the library. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fpvandoorn suggested in #3603 swapping the order of some
[fintype A] [decidable_eq A]arguments to solve a linter problem with slow typeclass lookup.The reasoning is that Lean solves typeclass search problems from right to left, and
fintypethan it hasdecidable_eq, so we can fail earlier iffintypecomes second[decidable_eq]can already be slow, so it's better to avoid it.This PR applies this suggestion across the library.