Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/special_functions/pow): Added lemmas for rpow of neg exponent #3715

Closed
wants to merge 2 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

@benjamindavidson benjamindavidson commented Aug 7, 2020

I noticed that the library was missing some lemmas regarding the bounds of rpow of a negative exponent so I added them. I cleaned up the other similar preexisting lemmas for consistency. I then repeated the process for nnreal lemmas.


I chose to use ' in the naming of the lemmas that deal with a negative exponent.

@benjamindavidson benjamindavidson changed the title Added lemmas for rpow of neg exponent feat(analysis/special_functions/pow): Added lemmas for rpow of neg exponent Aug 7, 2020
@benjamindavidson benjamindavidson added the awaiting-review The author would like community review of the PR label Aug 7, 2020
Copy link
Member

@ChrisHughes24 ChrisHughes24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some name changes, there are a few lemmas that need descriptive names that I didn't ment

src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 7, 2020
@benjamindavidson
Copy link
Collaborator Author

benjamindavidson commented Aug 7, 2020

Just some name changes, there are a few lemmas that need descriptive names that I didn't ment

I was mimicking the names of the preexisting lemmas. But I will gladly change them to match the pattern that you've suggested if that is preferable.

@benjamindavidson benjamindavidson added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 10, 2020
@semorrison
Copy link
Collaborator

@benjamindavidson it's helpful in the review process if you can click "resolve conversation" on items that have uncontroversially been solved, so new reviewers coming to the PR don't have to analyse what has and hasn't been done.

@benjamindavidson
Copy link
Collaborator Author

@benjamindavidson it's helpful in the review process if you can click "resolve conversation" on items that have uncontroversially been solved, so new reviewers coming to the PR don't have to analyse what has and hasn't been done.

Noted! Thanks for the advice and please do excuse my inexperience.

Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a way this is the hardest kind of PR to review! All looks good to me. But I could stare at these different permutations for an hour and still miss one with the wrong name. If someone else agrees with me that these look right let's merge.

Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 15, 2020
bors bot pushed a commit that referenced this pull request Aug 15, 2020
…ponent (#3715)

I noticed that the library was missing some lemmas regarding the bounds of rpow of a negative exponent so I added them. I cleaned up the other similar preexisting lemmas for consistency. I then repeated the process for nnreal lemmas.
@bors
Copy link

bors bot commented Aug 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions/pow): Added lemmas for rpow of neg exponent [Merged by Bors] - feat(analysis/special_functions/pow): Added lemmas for rpow of neg exponent Aug 15, 2020
@bors bors bot closed this Aug 15, 2020
@bors bors bot deleted the rpow_bound branch August 15, 2020 14:12
bors bot pushed a commit that referenced this pull request Sep 8, 2020
…nnreal (#4039)

Continuation of #3715. Added lemmas in `ennreal` corresponding to the `real` and `nnreal` lemmas added in that PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants