[Merged by Bors] - chore(algebra/ordered_field): cleanup #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* drop `mul_zero_lt_mul_inv_of_pos` and `mul_zero_lt_mul_inv_of_neg`; * add `iff` lemmas `one_div_pos/neg/nonneg/nonpos` replacing old implications; * some lemmas now assume `≤` instead of `<`; * rename `mul_lt_of_gt_div_of_neg` to `mul_ot_of_div_lt_of_neg` replacing `>` by `<`. * add `mul_sub_mul_div_mul_neg_iff` and `mul_sub_mul_div_mul_nonpos_iff`, generate implications using `alias`; * drop `div_pos_of_pos_of_pos` (use `div_pos`) and `div_nonneg_of_nonneg_of_pos` (use `div_nonneg`); * replace `div_nonpos_of_nonpos_of_pos` with `div_nonpos_of_nonpos_of_nonneg`; * replace `div_nonpos_of_nonneg_of_neg` with `div_nonpos_of_nonneg_of_nonpos`; * replace `div_mul_le_div_mul_of_div_le_div_pos` and `div_mul_le_div_mul_of_div_le_div_pos'` with `div_mul_le_div_mul_of_div_le_div_nonneg`; I failed to find in the history why we had two equivalent lemmas.
sgouezel
reviewed
Aug 9, 2020
sgouezel
added
awaiting-author
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
* merge `le_mul_of_ge_one_right` and `le_mul_of_one_le_right'` into `le_mul_of_one_le_right`, rename old `le_mul_of_one_le_right` to `le_mul_of_one_le_right'`; * ditto with `le_mul_of_ge_one_left`, `le_mul_of_one_le_left', and `le_mul_of_one_le_left'`; * ditto with `lt_mul_of_gt_one_right`, `lt_mul_of_one_lt_right`, and `lt_mul_of_one_lt_right'`; * rename `mul_lt_of_div_lt_of_neg` to `mul_lt_of_neg_of_div_lt`; * rename `div_lt_of_mul_lt_of_pos` to `div_lt_of_pos_of_lt_mul`; * rename `div_lt_of_mul_gt_of_neg` to `div_lt_of_neg_of_mul_lt`;
urkud
added
awaiting-review
* rename `mul_le_of_div_le_of_neg` to `mul_le_of_neg_of_div_le`; * rename `div_le_of_mul_le_of_neg` to `div_le_of_neg_of_mul_le`; * rename `div_lt_div_of_lt_of_pos` to `div_lt_div_of_pos_of_lt`, swap arguments; * rename `div_le_div_of_le_of_pos` to `div_le_div_of_pos_of_le`, swap arguments; * rename `div_lt_div_of_lt_of_neg` to `div_lt_div_of_neg_of_lt`, swap arguments; * rename `div_le_div_of_le_of_neg` to `div_le_div_of_neg_of_le`, swap arguments; * rename `one_div_lt_one_div_of_lt_of_neg` to `one_div_lt_one_div_of_neg_of_lt`; * rename `one_div_le_one_div_of_le_of_neg` to `one_div_le_one_div_of_neg_of_le`; * rename `le_of_one_div_le_one_div_of_neg` to `le_of_neg_of_one_div_le_one_div`; * rename `lt_of_one_div_lt_one_div_of_neg` to `lt_of_neg_of_one_div_lt_one_div`; * rename `one_div_le_of_one_div_le_of_pos` to `one_div_le_of_pos_of_one_div_le`; * rename `one_div_le_of_one_div_le_of_neg` to `one_div_le_of_neg_of_one_div_le`;
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2020
* drop `mul_zero_lt_mul_inv_of_pos` and `mul_zero_lt_mul_inv_of_neg`; * add `iff` lemmas `one_div_pos/neg/nonneg/nonpos` replacing old implications; * some lemmas now assume `≤` instead of `<`; * rename `mul_lt_of_gt_div_of_neg` to `mul_lt_of_neg_of_div_lt` replacing `>` by `<`. * add `mul_sub_mul_div_mul_neg_iff` and `mul_sub_mul_div_mul_nonpos_iff`, generate implications using `alias`; * drop `div_pos_of_pos_of_pos` (use `div_pos`) and `div_nonneg_of_nonneg_of_pos` (use `div_nonneg`); * replace `div_nonpos_of_nonpos_of_pos` with `div_nonpos_of_nonpos_of_nonneg`; * replace `div_nonpos_of_nonneg_of_neg` with `div_nonpos_of_nonneg_of_nonpos`; * replace `div_mul_le_div_mul_of_div_le_div_pos` and `div_mul_le_div_mul_of_div_le_div_pos'` with `div_mul_le_div_mul_of_div_le_div_nonneg`; I failed to find in the history why we had two equivalent lemmas. * merge `le_mul_of_ge_one_right` and `le_mul_of_one_le_right'` into `le_mul_of_one_le_right`, rename old `le_mul_of_one_le_right` to `le_mul_of_one_le_right'`; * ditto with `le_mul_of_ge_one_left`, `le_mul_of_one_le_left`, and `le_mul_of_one_le_left'`; * ditto with `lt_mul_of_gt_one_right`, `lt_mul_of_one_lt_right`, and `lt_mul_of_one_lt_right'`; * rename `div_lt_of_mul_lt_of_pos` to `div_lt_of_pos_of_lt_mul`; * rename `div_lt_of_mul_gt_of_neg` to `div_lt_of_neg_of_mul_lt`; * rename `mul_le_of_div_le_of_neg` to `mul_le_of_neg_of_div_le`; * rename `div_le_of_mul_le_of_neg` to `div_le_of_neg_of_mul_le`; * rename `div_lt_div_of_lt_of_pos` to `div_lt_div_of_pos_of_lt`, swap arguments; * rename `div_le_div_of_le_of_pos` to `div_le_div_of_pos_of_le`, swap arguments; * rename `div_lt_div_of_lt_of_neg` to `div_lt_div_of_neg_of_lt`, swap arguments; * rename `div_le_div_of_le_of_neg` to `div_le_div_of_neg_of_le`, swap arguments; * rename `one_div_lt_one_div_of_lt_of_neg` to `one_div_lt_one_div_of_neg_of_lt`; * rename `one_div_le_one_div_of_le_of_neg` to `one_div_le_one_div_of_neg_of_le`; * rename `le_of_one_div_le_one_div_of_neg` to `le_of_neg_of_one_div_le_one_div`; * rename `lt_of_one_div_lt_one_div_of_neg` to `lt_of_neg_of_one_div_lt_one_div`; * rename `one_div_le_of_one_div_le_of_pos` to `one_div_le_of_pos_of_one_div_le`; * rename `one_div_le_of_one_div_le_of_neg` to `one_div_le_of_neg_of_one_div_le`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mul_zero_lt_mul_inv_of_posandmul_zero_lt_mul_inv_of_neg;ifflemmasone_div_pos/neg/nonneg/nonposreplacing oldimplications;
≤instead of<;mul_lt_of_gt_div_of_negtomul_lt_of_neg_of_div_ltreplacing
>by<.mul_sub_mul_div_mul_neg_iffandmul_sub_mul_div_mul_nonpos_iff,generate implications using
alias;div_pos_of_pos_of_pos(usediv_pos) anddiv_nonneg_of_nonneg_of_pos(usediv_nonneg);div_nonpos_of_nonpos_of_poswithdiv_nonpos_of_nonpos_of_nonneg;div_nonpos_of_nonneg_of_negwithdiv_nonpos_of_nonneg_of_nonpos;div_mul_le_div_mul_of_div_le_div_posanddiv_mul_le_div_mul_of_div_le_div_pos'withdiv_mul_le_div_mul_of_div_le_div_nonneg; I failed to findin the history why we had two equivalent lemmas.
le_mul_of_ge_one_rightandle_mul_of_one_le_right'intole_mul_of_one_le_right, rename oldle_mul_of_one_le_righttole_mul_of_one_le_right';le_mul_of_ge_one_left,le_mul_of_one_le_left, andle_mul_of_one_le_left';lt_mul_of_gt_one_right,lt_mul_of_one_lt_right, andlt_mul_of_one_lt_right';div_lt_of_mul_lt_of_postodiv_lt_of_pos_of_lt_mul;div_lt_of_mul_gt_of_negtodiv_lt_of_neg_of_mul_lt;mul_le_of_div_le_of_negtomul_le_of_neg_of_div_le;div_le_of_mul_le_of_negtodiv_le_of_neg_of_mul_le;div_lt_div_of_lt_of_postodiv_lt_div_of_pos_of_lt, swaparguments;
div_le_div_of_le_of_postodiv_le_div_of_pos_of_le, swaparguments;
div_lt_div_of_lt_of_negtodiv_lt_div_of_neg_of_lt, swaparguments;
div_le_div_of_le_of_negtodiv_le_div_of_neg_of_le, swaparguments;
one_div_lt_one_div_of_lt_of_negtoone_div_lt_one_div_of_neg_of_lt;one_div_le_one_div_of_le_of_negtoone_div_le_one_div_of_neg_of_le;le_of_one_div_le_one_div_of_negtole_of_neg_of_one_div_le_one_div;lt_of_one_div_lt_one_div_of_negtolt_of_neg_of_one_div_lt_one_div;one_div_le_of_one_div_le_of_postoone_div_le_of_pos_of_one_div_le;one_div_le_of_one_div_le_of_negtoone_div_le_of_neg_of_one_div_le.