[Merged by Bors] - chore(linear_algebra/basic): rewrite p.comap q.subtype to comap q.subtype p
#3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subtype p` @PatrickMassot requested this change in the review of #3720.
Vierkantor
added
easy
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2020
…subtype p` (#3725) @PatrickMassot requested this change in the review of #3720: > I find this statement very difficult to read. I think this is a bad use of dot notation, it really feels like `p` is pulling back `q.subtype` instead of the other way around (and even the docstring is suggesting that!). The same problem happens with filter.(co)map and always try to avoid it. > I would open submodule and then write `comap q.subtype p ≃ₗ[R] p`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
p.comap q.subtype to comap q.subtype pp.comap q.subtype to comap q.subtype p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PatrickMassot requested this change in the review of #3720: