[Merged by Bors] - refactor(algebra/associated): change several instances from [integral_domain] to [comm_cancel_monoid_with_zero] #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awainverse
added
the
awaiting-review
semorrison
approved these changes
Aug 12, 2020
Vierkantor
requested changes
Aug 12, 2020
Vierkantor
added
awaiting-author
awainverse
added
awaiting-review
rwbarton
approved these changes
Aug 13, 2020
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2020
…_domain] to [comm_cancel_monoid_with_zero] (#3744) defines `comm_cancel_monoid_with_zero` replaces some `integral_domain` instances with `comm_cancel_monoid_with_zero` prepares the API for refactoring `normalization_domain`, `gcd_domain`, and `unique_factorization_domain` to monoids Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defines
comm_cancel_monoid_with_zeroreplaces some
integral_domaininstances withcomm_cancel_monoid_with_zeroprepares the API for refactoring
normalization_domain,gcd_domain, andunique_factorization_domainto monoids