Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/euclidean_domain): some cleanup #3752

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(algebra/euclidean_domain): some cleanup #3752

wants to merge 2 commits into from

Conversation

fpvandoorn
Copy link
Member

Lower the priority of simp-lemmas which have an equivalent version in group_with_zero, so that the version of group_with_zero is found by squeeze_simp for types that have both structures.
Add docstrings
Remove outdated comment

@fpvandoorn fpvandoorn added the awaiting-review The author would like community review of the PR label Aug 12, 2020
@urkud
Copy link
Member

urkud commented Aug 13, 2020 •
edited

Please resolve merge conflict, then merge
bors d+

@bors
Copy link

bors bot commented Aug 13, 2020

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@robertylewis robertylewis added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Aug 13, 2020
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Aug 13, 2020
@fpvandoorn
fix(euclidean_domain): lower priority of simp lemmas
abaeb6b 
this ensures that the simp lemmas for group_with_zero will be tried first
@fpvandoorn
add docstrings
925e324
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 15, 2020
@fpvandoorn fpvandoorn added the delegated The PR author may merge after reviewing final suggestions. label Aug 15, 2020
@fpvandoorn fpvandoorn mentioned this pull request Aug 15, 2020
Closed
@fpvandoorn
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 16, 2020
bors bot pushed a commit that referenced this pull request Aug 16, 2020
@fpvandoorn
feat(algebra/euclidean_domain): some cleanup (#3752)
20fe4a1 
Lower the priority of simp-lemmas which have an equivalent version in `group_with_zero`, so that the version of `group_with_zero` is found by `squeeze_simp` for types that have both structures.
Add docstrings
Remove outdated comment
@bors
Copy link

bors bot commented Aug 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/euclidean_domain): some cleanup [Merged by Bors] - feat(algebra/euclidean_domain): some cleanup Aug 16, 2020
@bors bors bot closed this Aug 16, 2020
@bors bors bot deleted the euclidean_domain_fix branch August 16, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpvandoorn @urkud @robertylewis