-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(data/list/tfae): tfae.out #3774
Conversation
Is there any reason to keep the old version? |
Not really, except for possible compatibility concerns. |
There was a request recently for a version of |
This PR has nothing to do with the |
Why don't we try to make this new version |
LGTM. bors merge |
This version of `tfae.out` has slightly better automatic reduction behavior: if `h : [a, b, c].tfae` then the original of `h.out 1 2` proves `[a, b, c].nth_le 1 _ <-> [a, b, c].nth_le 2 _` while the new version of `h.out 1 2` proves `b <-> c`. These are the same, of course, and you can mostly use them interchangeably, but the second one is a bit nicer to look at (and possibly works better with e.g. subsequent rewrites).
Pull request successfully merged into master. Build succeeded: |
This version of
tfae.out
has slightly better automatic reduction behavior: ifh : [a, b, c].tfae
then the original ofh.out 1 2
proves[a, b, c].nth_le 1 _ <-> [a, b, c].nth_le 2 _
while the new version ofh.out 1 2
provesb <-> c
. These are the same, of course, and you can mostly use them interchangeably, but the second one is a bit nicer to look at (and possibly works better with e.g. subsequent rewrites).