Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/list/tfae): tfae.out #3774

Closed
wants to merge 2 commits into from
Closed

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Aug 14, 2020

This version of tfae.out has slightly better automatic reduction behavior: if h : [a, b, c].tfae then the original of h.out 1 2 proves [a, b, c].nth_le 1 _ <-> [a, b, c].nth_le 2 _ while the new version of h.out 1 2 proves b <-> c. These are the same, of course, and you can mostly use them interchangeably, but the second one is a bit nicer to look at (and possibly works better with e.g. subsequent rewrites).

@cipher1024
Copy link
Collaborator

Is there any reason to keep the old version?

@digama0
Copy link
Member Author

digama0 commented Aug 14, 2020

Not really, except for possible compatibility concerns.

@cipher1024
Copy link
Collaborator

There was a request recently for a version of tfae where propositions are named instead of numbered. I think we might want to be careful to not have too many different ways of using this tactic. And in the case of the named proposition feature, I think a case could be made to keep only that version.

@digama0
Copy link
Member Author

digama0 commented Aug 14, 2020

This PR has nothing to do with the tfae tactic, it's just a theorem that lets you use the result of a tfae once it's been proved.

@jcommelin
Copy link
Member

Not really, except for possible compatibility concerns.

Why don't we try to make this new version out (and remove the existing one) and see what CI thinks of that?

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Aug 15, 2020
@semorrison
Copy link
Collaborator

LGTM.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 15, 2020
@jcommelin jcommelin changed the title feat(data/list/tfae): tfae.out' refactor(data/list/tfae): tfae.out Aug 15, 2020
bors bot pushed a commit that referenced this pull request Aug 15, 2020
This version of `tfae.out` has slightly better automatic reduction behavior: if `h : [a, b, c].tfae` then the original of `h.out 1 2` proves `[a, b, c].nth_le 1 _ <-> [a, b, c].nth_le 2 _` while the new version of `h.out 1 2` proves `b <-> c`. These are the same, of course, and you can mostly use them interchangeably, but the second one is a bit nicer to look at (and possibly works better with e.g. subsequent rewrites).
@bors
Copy link

bors bot commented Aug 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/list/tfae): tfae.out [Merged by Bors] - refactor(data/list/tfae): tfae.out Aug 15, 2020
@bors bors bot closed this Aug 15, 2020
@bors bors bot deleted the tfae_out branch August 15, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants