Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(set_theory/pgame): rename pgame lemma #3775

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - refactor(set_theory/pgame): rename pgame lemma #3775

wants to merge 2 commits into from

Conversation

foxthomson
Copy link
Collaborator

@foxthomson foxthomson commented Aug 14, 2020 •
edited by robertylewis

Renamed move_left_right_moves_neg_symm to move_left_left_moves_neg_symm to make it consistent with the other 3 related lemmas

@foxthomson
Rename pgame lemma
632ea29 
Renamed move_right_right_moves_neg_symm to move_right_left_moves_neg_symm to make it consistant  with the other 3 related lemmas
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Aug 15, 2020
@semorrison
Copy link
Collaborator

I think you've renamed the wrong lemma. The one you changed is correct, it's move_left_right_moves_neg_symm that needs to be renamed.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 15, 2020
@jcommelin
Copy link
Member

Also, please update the PR title following the commit guidelines.

@foxthomson foxthomson changed the title Rename pgame lemma refactor(set_theory/pgame): rename pgame lemma Aug 15, 2020
@foxthomson
Copy link
Collaborator Author

Sorry, I thought the (right|left)_moves referred to the type of i, I have corrected it now.

@foxthomson foxthomson added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 15, 2020
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 15, 2020
bors bot pushed a commit that referenced this pull request Aug 15, 2020
@foxthomson
refactor(set_theory/pgame): rename pgame lemma (#3775)
9ac6e8a 
Renamed `move_left_right_moves_neg_symm` to `move_left_left_moves_neg_symm` to make it consistent with the other 3 related lemmas
@bors
Copy link

bors bot commented Aug 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(set_theory/pgame): rename pgame lemma [Merged by Bors] - refactor(set_theory/pgame): rename pgame lemma Aug 15, 2020
@bors bors bot closed this Aug 15, 2020
@bors bors bot deleted the pgame-naming branch August 15, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@foxthomson @semorrison @jcommelin @robertylewis