Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(ring_theory): delete is_algebra_tower #3785

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(ring_theory): delete is_algebra_tower #3785

wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

Delete the abbreviation is_algebra_tower for is_scalar_tower, and replace all references (including the usages of the is_algebra_tower namespace) with is_scalar_tower. Documentation should also have been updated accordingly.

This change was requested in a comment on #3717.

@Vierkantor
chore(ring_theory): delete is_algebra_tower
dd1a771 
Delete the abbreviation `is_algebra_tower` for `is_scalar_tower`,
and replace all references (including the usages of the `is_algebra_tower`
namespace) with `is_scalar_tower`. Documentation should also have been
updated accordingly.

This change was requested in a comment on #3717.
@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Aug 15, 2020
@Vierkantor Vierkantor mentioned this pull request Aug 15, 2020
Closed
@Nicknamen
Copy link
Collaborator

Nicknamen commented Aug 15, 2020 •
edited
Loading

That's great! It seems like there is not a lot to review here! Can I give you the permission to merge already?

@Vierkantor
Copy link
Collaborator Author

It's better to let at least one (other) maintainer take a look, although with the current backlog of PRs they might just give you the permission to merge it after reviewing.

PatrickMassot
PatrickMassot reviewed Aug 15, 2020
View reviewed changes
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you rename the file is_algebra_tower?

src/ring_theory/algebra.lean Outdated Show resolved Hide resolved
src/ring_theory/algebra_tower.lean Outdated Show resolved Hide resolved
@Vierkantor @PatrickMassot
Apply suggestions from code review
c22ef9e 
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@Vierkantor
Copy link
Collaborator Author

Shouldn't you rename the file is_algebra_tower?

(It is currently called algebra_tower.lean, not is_algebra_tower.lean.) I think algebra_tower fits the description of the current contents: is_scalar_tower under the assumption that the has_scalar instances come from algebra. If you expect that we will have results using is_scalar_tower on rings without an algebra instance between them, then I agree we should rename it.

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 15, 2020
bors bot pushed a commit that referenced this pull request Aug 15, 2020
@Vierkantor
chore(ring_theory): delete is_algebra_tower (#3785)
9216dd7 
Delete the abbreviation `is_algebra_tower` for `is_scalar_tower`, and replace all references (including the usages of the `is_algebra_tower` namespace) with `is_scalar_tower`. Documentation should also have been updated accordingly.

This change was requested in a comment on #3717.




Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(ring_theory): delete is_algebra_tower [Merged by Bors] - chore(ring_theory): delete is_algebra_tower Aug 15, 2020
@bors bors bot closed this Aug 15, 2020
@bors bors bot deleted the delete_is_algebra_tower branch August 15, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

@kckennylau kckennylau Awaiting requested review from kckennylau

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vierkantor @Nicknamen @PatrickMassot