Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - docs(category_theory/limits/cones): cones documentation and equivalence fixup #3795

Closed
wants to merge 2 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Aug 15, 2020

Mostly adding documentation in ct.limits.cones, but also shortened a couple of proofs. I also adjusted a couple of statements for is_equivalence to match the is_equivalence projections which are meant to be used (these statements were only used for cones anyway).

@b-mehta b-mehta added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Aug 15, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

src/category_theory/limits/cones.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 15, 2020

✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Johan Commelin <johan@commelin.net>
@b-mehta
Copy link
Collaborator Author

b-mehta commented Aug 15, 2020

bors r+

bors bot pushed a commit that referenced this pull request Aug 15, 2020
…ce fixup (#3795)

Mostly adding documentation in `ct.limits.cones`, but also shortened a couple of proofs. I also adjusted a couple of statements for `is_equivalence` to match the `is_equivalence` projections which are meant to be used (these statements were only used for cones anyway).
@bors
Copy link

bors bot commented Aug 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs(category_theory/limits/cones): cones documentation and equivalence fixup [Merged by Bors] - docs(category_theory/limits/cones): cones documentation and equivalence fixup Aug 16, 2020
@bors bors bot closed this Aug 16, 2020
@bors bors bot deleted the cone-docs branch August 16, 2020 01:06
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants