[Merged by Bors] - feat(lint): improved ge_or_gt linter #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
the
blocked-by-other-PR
github-actions
bot
added
the
merge-conflict
fpvandoorn
force-pushed
the
ge_gt_linter
branch
from
016fa09
to
10f925f
Compare
fpvandoorn
changed the title
github-actions
bot
removed
the
merge-conflict
fpvandoorn
force-pushed
the
ge_gt_linter
branch
from
10f925f
to
2e135a1
Compare
fpvandoorn
added
awaiting-review
fpvandoorn
changed the title
| @@ -1262,7 +1262,7 @@ lemma remove_nth_insert_nth (n:ℕ) (l : list α) : (l.insert_nth n a).remove_nt | |||
| by rw [remove_nth_eq_nth_tail, insert_nth, modify_nth_tail_modify_nth_tail_same]; | |||
| from modify_nth_tail_id _ _ | |||
|
|
|||
| lemma insert_nth_remove_nth_of_ge : ∀n m as, n < length as → m ≥ n → | |||
| lemma insert_nth_remove_nth_of_ge : ∀n m as, n < length as → n ≤ m → | |||
There was a problem hiding this comment.
Should the name be changed too?
There was a problem hiding this comment.
maybe... However, insert_nth_remove_nth_of_le already exists, with n and m in the other order.
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2020
The linter will now correctly accepts occurrences of `f (≥)` and `∃ x ≥ t, b` The linter will still raise a false positive on `∃ x y ≥ t, b` (with 2+ bound variables in a single binder that involves `>/≥`) In contrast to the previous version of the linter, this one *does* check hypotheses. This should reduce the `@[nolint ge_or_gt]` attributes from ~160 to ~10.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter will now correctly accepts occurrences of
f (≥)and∃ x ≥ t, bThe linter will still raise a false positive on
∃ x y ≥ t, b(with 2+ bound variables in a single binder that involves>/≥)In contrast to the previous version of the linter, this one does check hypotheses.
This should reduce the
@[nolint ge_or_gt]attributes from ~160 to ~10.Until #3808 and #3809 are merged, the linter will raise many errors.