Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/DVR,padics/padic_integers): characterize ideals of DVRs, apply to Z_p #3827

Closed
wants to merge 24 commits into from
Closed

[Merged by Bors] - feat(ring_theory/DVR,padics/padic_integers): characterize ideals of DVRs, apply to Z_p #3827

wants to merge 24 commits into from

Conversation

robertylewis
Copy link
Member

Also introduce the p-adic valuation on Z_p, stolen from the perfectoid project.

Coauthored by: Johan Commelin johan@commelin.net

@robertylewis robertylewis added the awaiting-review The author would like community review of the PR label Aug 16, 2020
@PatrickMassot
Copy link
Member

Could you use type ascription instead of all those ↑?

@jcommelin
Copy link
Member

@PatrickMassot for ↑u⁻¹ specifically, I would like to make an exception. This comes up quite often, and type (u⁻¹ : units _) is an ugly mouthful. I would say that this is an idiom to say, hey, I've got this unit, and I want to consider it's inverse as element of the underlying ring.... but Lean is stupid and looks for has_inv in the wrong place, so here you have a cookie up-arrow.
Do you think that makes sense?

Arguably, the same could be said for ↑p | x.

@PatrickMassot
Copy link
Member

I would still change that show ↑p ^ -valuation x ≤ ↑p ^ 0,

PatrickMassot
PatrickMassot reviewed Aug 17, 2020
View reviewed changes
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 17, 2020
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Aug 17, 2020
bors bot pushed a commit that referenced this pull request Aug 17, 2020
@robertylewis @jcommelin
feat(ring_theory/DVR,padics/padic_integers): characterize ideals of D…
3edf2b2 
…VRs, apply to `Z_p` (#3827)

Also introduce the p-adic valuation on `Z_p`, stolen from the perfectoid project.

Coauthored by: Johan Commelin <johan@commelin.net>



Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Aug 17, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/DVR,padics/padic_integers): characterize ideals of DVRs, apply to Z_p [Merged by Bors] - feat(ring_theory/DVR,padics/padic_integers): characterize ideals of DVRs, apply to Z_p Aug 17, 2020
@bors bors bot closed this Aug 17, 2020
@bors bors bot deleted the padic-dvr-1 branch August 17, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertylewis @PatrickMassot @jcommelin