Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/separable): a separable polynomial splits into a product of unique X - C a #3877

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(ring_theory/separable): a separable polynomial splits into a product of unique X - C a #3877

wants to merge 3 commits into from

Conversation

Vierkantor
Copy link
Collaborator

Bonus result: the degree of a separable polynomial is the number of roots
in the field where it splits.

@Vierkantor
feat(ring_theory/separable): a separable polynomial splits into a pro…
91a4cb1 
…duct of unique `X - C a`

Bonus result: the degree of a separable polynomial is the number of roots
in the field where it splits.
@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Aug 20, 2020
jcommelin
jcommelin requested changes Aug 20, 2020
View reviewed changes
src/data/polynomial/ring_division.lean Outdated Show resolved Hide resolved
src/data/polynomial/ring_division.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 20, 2020
@Vierkantor @jcommelin
finset_prod -> prod
538f604 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 20, 2020
jcommelin
jcommelin approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 20, 2020
bors bot pushed a commit that referenced this pull request Aug 20, 2020
@Vierkantor
feat(ring_theory/separable): a separable polynomial splits into a pro…
901c5bc 
…duct of unique `X - C a` (#3877)

Bonus result: the degree of a separable polynomial is the number of roots
in the field where it splits.




Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 20, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/separable): a separable polynomial splits into a product of unique X - C a [Merged by Bors] - feat(ring_theory/separable): a separable polynomial splits into a product of unique X - C a Aug 20, 2020
@bors bors bot closed this Aug 20, 2020
@bors bors bot deleted the separable_roots branch August 20, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vierkantor @jcommelin