Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/polynomial/eval): eval_finset.prod #3903

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat(data/polynomial/eval): eval_finset.prod #3903

wants to merge 8 commits into from

Conversation

stanescuUW
Copy link
Collaborator

Evaluating commutes with finset.prod; useful in a variety of situations in numerical analysis.

@stanescuUW stanescuUW added the awaiting-review The author would like community review of the PR label Aug 21, 2020
@bryangingechen bryangingechen changed the title feat(eval_finset.prod) : data/polynomial/eval.lean feat(data/polynomial/eval): eval_finset.prod Aug 21, 2020
jcommelin
jcommelin requested changes Aug 22, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left some comments.

src/data/polynomial/eval.lean Outdated Show resolved Hide resolved
src/data/polynomial/eval.lean Outdated Show resolved Hide resolved
src/data/polynomial/eval.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 22, 2020
stanescuUW and others added 4 commits August 22, 2020 06:56
@stanescuUW @jcommelin
Update src/data/polynomial/eval.lean
1391d9e 
Co-authored-by: Johan Commelin <johan@commelin.net>
@stanescuUW @jcommelin
Update src/data/polynomial/eval.lean
1b26818 
Co-authored-by: Johan Commelin <johan@commelin.net>
@stanescuUW @jcommelin
Update src/data/polynomial/eval.lean
ea66238 
Co-authored-by: Johan Commelin <johan@commelin.net>
@stanescuUW
Update eval.lean
95ca6eb
@stanescuUW
Copy link
Collaborator Author

@jcommelin Thanks for the suggestions, which have all been incorporated.

@stanescuUW stanescuUW added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 22, 2020
jcommelin
jcommelin requested changes Aug 22, 2020
View reviewed changes
src/data/polynomial/eval.lean Outdated Show resolved Hide resolved
@stanescuUW @jcommelin
Update src/data/polynomial/eval.lean
f18d6a1 
Co-authored-by: Johan Commelin <johan@commelin.net>
@stanescuUW @jcommelin
Update src/data/polynomial/eval.lean
e4f3cfe 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jcommelin
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 22, 2020
bors bot pushed a commit that referenced this pull request Aug 22, 2020
@stanescuUW
feat(data/polynomial/eval): eval_finset.prod (#3903)
6a85278 
Evaluating commutes with finset.prod; useful in a variety of situations in numerical analysis.
@bors
Copy link

bors bot commented Aug 22, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial/eval): eval_finset.prod [Merged by Bors] - feat(data/polynomial/eval): eval_finset.prod Aug 22, 2020
@bors bors bot closed this Aug 22, 2020
@bors bors bot deleted the poly_eval branch August 22, 2020 15:13
@stanescuUW
Copy link
Collaborator Author

@jcommelin Johan, here is a problem with changing the name from eval_finset.prod to the simpler eval_prod: if one wants to add the corresponding result for a sum over a finset (instead of a prod) and correspondingly name it eval_sum, that name is already taken by a previous lemma. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin requested changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stanescuUW @jcommelin