Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(data/sigma/basic): rename ext to sigma.ext #3916

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix(data/sigma/basic): rename ext to sigma.ext #3916

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 23, 2020

@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Aug 23, 2020
@fpvandoorn
Copy link
Member

I feel like we should actually use namespace sigma and namespace psigma in that file, instead of writing sigma. in front of every definition. But this is definitely a good change.

bors d+

@bors
Copy link

bors bot commented Aug 23, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@fpvandoorn fpvandoorn added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 23, 2020
@urkud
Copy link
Member Author

urkud commented Aug 23, 2020

I prefer to merge this and add namespace later: I have a few other refactors to do tonight.
bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 23, 2020
bors bot pushed a commit that referenced this pull request Aug 23, 2020
@urkud
fix(data/sigma/basic): rename ext to sigma.ext (#3916)
7d88a30
@bors
Copy link

bors bot commented Aug 23, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(data/sigma/basic): rename ext to sigma.ext [Merged by Bors] - fix(data/sigma/basic): rename ext to sigma.ext Aug 23, 2020
@bors bors bot closed this Aug 23, 2020
@bors bors bot deleted the sigma-ext branch August 23, 2020 07:56
@fpvandoorn fpvandoorn mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @fpvandoorn