-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(finsupp/basic): add hom_ext #3941
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbuzzard
added
the
awaiting-review
The author would like community review of the PR
label
Aug 25, 2020
Vierkantor
reviewed
Aug 26, 2020
Vierkantor
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Aug 26, 2020
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Vierkantor
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bors r+
👎 Rejected by label |
Vierkantor
removed
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Aug 26, 2020
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Aug 26, 2020
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2020
Two R-module homs from finsupp X R which agree on `single x 1` agree everywhere. ``` lemma hom_ext [semiring β] [add_comm_monoid γ] [semimodule β γ] (φ ψ : (α →₀ β) →ₗ[β] γ) (h : ∀ a : α, φ (single a 1) = ψ (single a 1)) : φ = ψ ```
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(finsupp/basic): add hom_ext
[Merged by Bors] - feat(finsupp/basic): add hom_ext
Aug 26, 2020
robertylewis
pushed a commit
that referenced
this pull request
Aug 31, 2020
Two R-module homs from finsupp X R which agree on `single x 1` agree everywhere. ``` lemma hom_ext [semiring β] [add_comm_monoid γ] [semimodule β γ] (φ ψ : (α →₀ β) →ₗ[β] γ) (h : ∀ a : α, φ (single a 1) = ψ (single a 1)) : φ = ψ ```
PatrickMassot
pushed a commit
that referenced
this pull request
Sep 8, 2020
Two R-module homs from finsupp X R which agree on `single x 1` agree everywhere. ``` lemma hom_ext [semiring β] [add_comm_monoid γ] [semimodule β γ] (φ ψ : (α →₀ β) →ₗ[β] γ) (h : ∀ a : α, φ (single a 1) = ψ (single a 1)) : φ = ψ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two R-module homs from finsupp X R which agree on
single x 1
agree everywhere.