Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits/concrete): simp lemmas #3973

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits/concrete): simp lemmas #3973

wants to merge 7 commits into from

Conversation

semorrison
Copy link
Collaborator

Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Aug 29, 2020
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 29, 2020
@semorrison semorrison removed the awaiting-author A reviewer has asked the author a question or requested changes label Aug 30, 2020
@semorrison semorrison mentioned this pull request Aug 31, 2020
Closed
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 1, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 1, 2020
jcommelin
jcommelin approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 2, 2020
bors bot pushed a commit that referenced this pull request Sep 2, 2020
@semorrison
feat(category_theory/limits/concrete): simp lemmas (#3973)
524c32c 
Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 2, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 2, 2020
@semorrison
feat(category_theory/limits/concrete): simp lemmas (#3973)
328a5c5 
Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 2, 2020

Build failed:

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 2, 2020
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Sep 2, 2020

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added the delegated The PR author may merge after reviewing final suggestions. label Sep 3, 2020
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
bors bot pushed a commit that referenced this pull request Sep 3, 2020
@semorrison
feat(category_theory/limits/concrete): simp lemmas (#3973)
6e15d55 
Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 3, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@bryangingechen
Copy link
Collaborator

@semorrison the build was failing earlier on staging, and it doesn't look like you merged master and fixed things before putting this back on the queue?
bors r-

@bors
Copy link

bors bot commented Sep 3, 2020

Canceled.

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
@semorrison
Copy link
Collaborator Author

Trying again after a merge!

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
bors bot pushed a commit that referenced this pull request Sep 3, 2020
@semorrison
feat(category_theory/limits/concrete): simp lemmas (#3973)
ba0a303 
Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 3, 2020

Build failed:

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
@semorrison @bryangingechen
Update src/category_theory/limits/concrete_category.lean
3880e03 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
bors bot pushed a commit that referenced this pull request Sep 3, 2020
@semorrison
feat(category_theory/limits/concrete): simp lemmas (#3973)
fa6485a 
Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 3, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits/concrete): simp lemmas [Merged by Bors] - feat(category_theory/limits/concrete): simp lemmas Sep 3, 2020
@bors bors bot closed this Sep 3, 2020
@bors bors bot deleted the concrete_category_limits branch September 3, 2020 11:59
PatrickMassot pushed a commit that referenced this pull request Sep 8, 2020
@semorrison @PatrickMassot
feat(category_theory/limits/concrete): simp lemmas (#3973)
ffea3eb 
Some specialisations of simp lemmas about (co)limits for concrete categories, where the equation in morphisms has been applied to an element.

This isn't exhaustive; just the things I've wanted recently.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @jcommelin @bryangingechen