[Merged by Bors] - feat(data/{sym2,sym}) decidable version of sym2.mem.other, filling out some of sym API #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `sym2.vmem` and replaces it with `sym2.mem.other'`, which can get the other element of a pair in the presence of decidable equality. Writing `sym2.mem.other'` was beyond my abilities when I created `sym2.vmem`, and seeing that vmem is extremely specialized and has no immediate use, it's probably best to remove it. Adds some assorted simp lemmas, and also an additional lemma that `sym2.mem.other` is, in some sense, an involution. Adds to the API for `sym`. This is from taking some of the interface for multisets. (This was from exploring whether `sym2 α` should be re-implemented as `sym α 2` and trying to add enough to `sym` to pull it off, but it doesn't seem to be worth it.) (I'm not committing a recursor for `sym α n`, which lets you represent elements as vectors of length `n`. It needs some cleanup.)
kmill
changed the title
semorrison
reviewed
Sep 6, 2020
robertylewis
added
awaiting-author
|
@jcommelin Fixed the import line (didn't mean to revert @semorrison's cleanup!) |
kmill
added
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
…t some of sym API (#4008) Removes `sym2.vmem` and replaces it with `sym2.mem.other'`, which can get the other element of a pair in the presence of decidable equality. Writing `sym2.mem.other'` was beyond my abilities when I created `sym2.vmem`, and seeing that vmem is extremely specialized and has no immediate use, it's probably best to remove it. Adds some assorted simp lemmas, and also an additional lemma that `sym2.mem.other` is, in some sense, an involution. Adds to the API for `sym`. This is from taking some of the interface for multisets. (I was exploring whether `sym2 α` should be re-implemented as `sym α 2` and trying to add enough to `sym` to pull it off, but it doesn't seem to be worth it in the end.) (I'm not committing a recursor for `sym α n`, which lets you represent elements by vectors of length `n`. It needs some cleanup.)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
sym2.vmemand replaces it withsym2.mem.other', which can get the other element of a pair in the presence of decidable equality. Writingsym2.mem.other'was beyond my abilities when I createdsym2.vmem, and seeing that vmem is extremely specialized and has no immediate use, it's probably best to remove it.Adds some assorted simp lemmas, and also an additional lemma that
sym2.mem.otheris, in some sense, an involution.Adds to the API for
sym. This is from taking some of the interface for multisets. (I was exploring whethersym2 αshould be re-implemented assym α 2and trying to add enough tosymto pull it off, but it doesn't seem to be worth it in the end.)(I'm not committing a recursor for
sym α n, which lets you represent elements by vectors of lengthn. It needs some cleanup.)