Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/eigenspace): add generalized eigenspaces #4015

Closed
wants to merge 7 commits into from

Conversation

abentkamp
Copy link
Collaborator

Add the definition of generalized eigenspaces, eigenvectors and eigenvalues. Add some basic lemmas about them.

Another step towards #3864.

src/algebra/group_power.lean Outdated Show resolved Hide resolved
src/algebra/group_power.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Show resolved Hide resolved
@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 1, 2020
@abentkamp abentkamp force-pushed the generalized-eigenspace branch 3 times, most recently from 114c57f to 8c329ac Compare September 1, 2020 11:00
@abentkamp abentkamp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 1, 2020
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 2, 2020
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest a tiny bit of proof golf, but I would also be happy with the proofs as they are.

bors d+

src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
src/linear_algebra/eigenspace.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 2, 2020

✌️ abentkamp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Vierkantor Vierkantor added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 2, 2020
abentkamp and others added 3 commits September 2, 2020 13:42
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@abentkamp
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 2, 2020
Add the definition of generalized eigenspaces, eigenvectors and eigenvalues. Add some basic lemmas about them.

Another step towards #3864.
@bors
Copy link

bors bot commented Sep 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/eigenspace): add generalized eigenspaces [Merged by Bors] - feat(linear_algebra/eigenspace): add generalized eigenspaces Sep 2, 2020
@bors bors bot closed this Sep 2, 2020
@bors bors bot deleted the generalized-eigenspace branch September 2, 2020 13:18
PatrickMassot pushed a commit that referenced this pull request Sep 8, 2020
Add the definition of generalized eigenspaces, eigenvectors and eigenvalues. Add some basic lemmas about them.

Another step towards #3864.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants