Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/filtered): finite diagrams in filtered categories admit cocones #4026

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(category_theory/filtered): finite diagrams in filtered categories admit cocones #4026

wants to merge 5 commits into from

Conversation

semorrison
Copy link
Collaborator

This is only step towards eventual results about filtered colimits commuting with finite limits, forget CommRing preserving filtered colimits, and applications to Scheme.

jcommelin
jcommelin reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks mostly good. sup_exists' has a pretty intimidating statement...

src/category_theory/filtered.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator Author

I think this looks mostly good. sup_exists' has a pretty intimidating statement...

I added some more documentation, explaining the difference between sup_exists and sup_exists'.

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Sep 3, 2020
jcommelin
jcommelin reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 3, 2020
bors bot pushed a commit that referenced this pull request Sep 3, 2020
@semorrison
feat(category_theory/filtered): finite diagrams in filtered categorie…
afafb92 
…s admit cocones (#4026)

This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bryangingechen
Copy link
Collaborator

The last build failed.
bors r-

Feel free to merge when it's fixed.

@bors
Copy link

bors bot commented Sep 3, 2020

Canceled.

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
bors bot pushed a commit that referenced this pull request Sep 3, 2020
@semorrison
feat(category_theory/filtered): finite diagrams in filtered categorie…
626e3be 
…s admit cocones (#4026)

This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 3, 2020

Canceled.

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2020
@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 3, 2020
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 3, 2020
@semorrison
Copy link
Collaborator Author

Okay, I added the missing docs. (They're not that long...)

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 3, 2020
bors bot pushed a commit that referenced this pull request Sep 3, 2020
@semorrison
feat(category_theory/filtered): finite diagrams in filtered categorie…
8b277a9 
…s admit cocones (#4026)

This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 3, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/filtered): finite diagrams in filtered categories admit cocones [Merged by Bors] - feat(category_theory/filtered): finite diagrams in filtered categories admit cocones Sep 3, 2020
@bors bors bot closed this Sep 3, 2020
@bors bors bot deleted the cocone_exists branch September 3, 2020 16:43
PatrickMassot pushed a commit that referenced this pull request Sep 8, 2020
@semorrison @PatrickMassot
feat(category_theory/filtered): finite diagrams in filtered categorie…
bd1b6e5 
…s admit cocones (#4026)

This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @bryangingechen @jcommelin