Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(data/mv_polynomial/pderivative): rename variables and file, make it universe polymorphic #4083

Closed
wants to merge 4 commits into from

Conversation

shingtaklam1324
Copy link
Collaborator

@shingtaklam1324 shingtaklam1324 commented Sep 9, 2020

This file originally used different variable names to the rest of mv_polynomial. I've changed it to now use the same conventions as the other files.

I also renamed the file to pderivative.lean to be consistent with derivative.lean for polynomials.

The types of the coefficient ring and the indexing variables are now universe polymorphic.

The diff shows it as new files, but the only changes are fixing the statements and proofs.


@shingtaklam1324 shingtaklam1324 added the awaiting-review The author would like community review of the PR label Sep 9, 2020
@robertylewis
Copy link
Member

As I recall, the mathematicians preferred to name the coefficient rings R and S instead of using Greek letters. This is why the old mv_polynomial.lean was half and half. Personally I'd be fine with changing α back to R in this file, but keeping σ, since S as the variable type (instead of the coefficient type) is confusing.

@robertylewis
Copy link
Member

There's another change (which is a good one, but should be noted in the first post so it ends up in the commit message): the types are now universe polymorphic.

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 9, 2020
@shingtaklam1324 shingtaklam1324 changed the title fix(data/mv_polynomial/pderivative): rename variables and file fix(data/mv_polynomial/pderivative): rename variables and file, make it universe polymorphic Sep 9, 2020
@shingtaklam1324 shingtaklam1324 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 9, 2020
@robertylewis
Copy link
Member

Thanks very much!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 9, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Idea for future work: make pderivative a bundled hom (add_monoid_hom, or maybe even linear_map).

@shingtaklam1324
Copy link
Collaborator Author

It's already an add_monoid_hom, but I'll take a look at linear_map

bors bot pushed a commit that referenced this pull request Sep 9, 2020
…it universe polymorphic (#4083)

This file originally used different variable names to the rest of `mv_polynomial`. I've changed it to now use the same conventions as the other files.

I also renamed the file to `pderivative.lean` to be consistent with `derivative.lean` for polynomials.

The types of the coefficient ring and the indexing variables are now universe polymorphic.

The diff shows it as new files, but the only changes are fixing the statements and proofs.
@jcommelin
Copy link
Member

It's already an add_monoid_hom, but I'll take a look at linear_map

@shingtaklam1324 No, I meant the actual pderivative declaration. (Instead of pderivative.add_monoid_hom).
So that pderivative (f + g) can be rewritten to pderivative f + pderivative g using add_monoid_hom.map_add.

@bors
Copy link

bors bot commented Sep 9, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(data/mv_polynomial/pderivative): rename variables and file, make it universe polymorphic [Merged by Bors] - fix(data/mv_polynomial/pderivative): rename variables and file, make it universe polymorphic Sep 9, 2020
@bors bors bot closed this Sep 9, 2020
@bors bors bot deleted the fix-pderivative branch September 9, 2020 18:04
bors bot pushed a commit that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants