-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix(data/mv_polynomial/pderivative): rename variables and file, make it universe polymorphic #4083
Conversation
As I recall, the mathematicians preferred to name the coefficient rings |
There's another change (which is a good one, but should be noted in the first post so it ends up in the commit message): the types are now universe polymorphic. |
Thanks very much! bors merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Idea for future work: make pderivative
a bundled hom (add_monoid_hom, or maybe even linear_map).
It's already an |
…it universe polymorphic (#4083) This file originally used different variable names to the rest of `mv_polynomial`. I've changed it to now use the same conventions as the other files. I also renamed the file to `pderivative.lean` to be consistent with `derivative.lean` for polynomials. The types of the coefficient ring and the indexing variables are now universe polymorphic. The diff shows it as new files, but the only changes are fixing the statements and proofs.
@shingtaklam1324 No, I meant the actual |
Pull request successfully merged into master. Build succeeded: |
…ap (#4095) Make `pderivative i` a linear map as suggested at #4083 (comment)
This file originally used different variable names to the rest of
mv_polynomial
. I've changed it to now use the same conventions as the other files.I also renamed the file to
pderivative.lean
to be consistent withderivative.lean
for polynomials.The types of the coefficient ring and the indexing variables are now universe polymorphic.
The diff shows it as new files, but the only changes are fixing the statements and proofs.