Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra): tiny missing pieces #4089

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(linear_algebra): tiny missing pieces #4089

wants to merge 3 commits into from

Conversation

PatrickMassot
Copy link
Member

From the sphere eversion project.

@PatrickMassot PatrickMassot added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Sep 9, 2020
bryangingechen
bryangingechen approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors d+

@bors
Copy link

bors bot commented Sep 10, 2020

✌️ PatrickMassot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 10, 2020
@PatrickMassot @bryangingechen
Update src/linear_algebra/finite_dimensional.lean
2ea2bcc 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@PatrickMassot
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 10, 2020
bors bot pushed a commit that referenced this pull request Sep 10, 2020
@PatrickMassot
feat(linear_algebra): tiny missing pieces (#4089)
47264da 
From the sphere eversion project.
@bors
Copy link

bors bot commented Sep 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra): tiny missing pieces [Merged by Bors] - feat(linear_algebra): tiny missing pieces Sep 10, 2020
@bors bors bot closed this Sep 10, 2020
@bors bors bot deleted the clm branch September 10, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PatrickMassot @bryangingechen