[Merged by Bors] - refactor(data/mv_polynomial): move smul lemmas into basic.lean
#4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shingtaklam1324
added
the
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
`C_mul'`, `smul_eq_C_mul` and `smul_eval` seemed a bit out of place in `comm_ring.lean`, since they only need `comm_semiring α`. So I moved them to `basic.lean` where they probably fit in a bit better? I've also golfed the proof of `smul_eq_C_mul`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
smul lemmas into basic.leansmul lemmas into basic.lean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C_mul',smul_eq_C_mulandsmul_evalseemed a bit out of place incomm_ring.lean, since they only needcomm_semiring α. So I moved them tobasic.leanwhere they probably fit in a bit better?I've also golfed the proof of
smul_eq_C_mul.