Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(category_theory/limits): remove unnecessary typeclass arguments #4141

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(category_theory/limits): remove unnecessary typeclass arguments #4141

wants to merge 1 commit into from

Conversation

semorrison
Copy link
Collaborator

Ongoing cleanup post #3995.

Previously we couldn't construct things like instance : has_kernel (0 : X \hom Y), because it wouldn't have agreed definitionally with more general instances. Now we can.

jcommelin
jcommelin approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 14, 2020
bors bot pushed a commit that referenced this pull request Sep 14, 2020
@semorrison
chore(category_theory/limits): remove unnecessary typeclass arguments (…
e355933 
…#4141)

Ongoing cleanup post #3995.

Previously we couldn't construct things like `instance : has_kernel (0 : X \hom Y)`, because it wouldn't have agreed definitionally with more general instances. Now we can.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory/limits): remove unnecessary typeclass arguments [Merged by Bors] - chore(category_theory/limits): remove unnecessary typeclass arguments Sep 14, 2020
@bors bors bot closed this Sep 14, 2020
@bors bors bot deleted the cleanup_instances branch September 14, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @jcommelin