[Merged by Bors] - feat(data/mv_polynomial): define comap #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no idea where 2017 came from
robertylewis
added
the
awaiting-review
Vierkantor
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
I would have expected to see a lemma along the lines of comap (rename f) x = x \circ f, but apparently rename should first be made an alg_hom. If you don't want to redefine rename, I'm happy with merging as is (after removing a few unnecessary brackets).
bors d+
|
✌️ robertylewis can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
|
@Vierkantor done |
|
Thanks! bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 18, 2020
More from the Witt vector branch. Co-authored by: Johan Commelin <johan@commelin.net> Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More from the Witt vector branch.
Co-authored by: Johan Commelin johan@commelin.net