Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/(lazy_)list): various lemmas and definitions #4172

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat(data/(lazy_)list): various lemmas and definitions #4172

wants to merge 15 commits into from

Conversation

cipher1024
Copy link
Collaborator

A bunch of lemmas and definitions about list, lazy_list and sigma

@cipher1024 cipher1024 mentioned this pull request Sep 17, 2020
Closed
@bryangingechen bryangingechen added the awaiting-review The author would like community review of the PR label Sep 17, 2020
cipher1024 and others added 2 commits September 17, 2020 00:10
@cipher1024
Update basic.lean
7c9d8c6
@cipher1024 @bryangingechen
Apply suggestions from code review
b86bdfe 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@cipher1024 @semorrison
Update src/data/list/basic.lean
abafcbf 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bryangingechen
bryangingechen reviewed Sep 17, 2020
View reviewed changes
src/data/lazy_list/basic.lean Outdated Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
bryangingechen
bryangingechen approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one stylistic nitpick and a question. Everything else seems good.

src/data/list/perm.lean Outdated Show resolved Hide resolved
@cipher1024
Update perm.lean
578f479 
Cut down long lines
semorrison
semorrison reviewed Sep 19, 2020
View reviewed changes
src/data/list/perm.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 19, 2020
@cipher1024 cipher1024 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 20, 2020
bryangingechen
bryangingechen approved these changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! @semorrison any other comments?

src/data/list/basic.lean Outdated Show resolved Hide resolved
@cipher1024 @bryangingechen
Apply suggestions from code review
e05fba5 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
robertylewis
robertylewis reviewed Sep 21, 2020
View reviewed changes
src/data/lazy_list/basic.lean Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
src/data/list/perm.lean Show resolved Hide resolved
src/data/list/zip.lean Outdated Show resolved Hide resolved
src/data/list/zip.lean Outdated Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 21, 2020
@cipher1024 cipher1024 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 21, 2020
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 22, 2020
@cipher1024 cipher1024 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 22, 2020
@semorrison
Copy link
Collaborator

Looks great!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 24, 2020
bors bot pushed a commit that referenced this pull request Sep 24, 2020
@cipher1024
feat(data/(lazy_)list): various lemmas and definitions (#4172)
96e81fa
@bors
Copy link

bors bot commented Sep 24, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/(lazy_)list): various lemmas and definitions [Merged by Bors] - feat(data/(lazy_)list): various lemmas and definitions Sep 24, 2020
@bors bors bot closed this Sep 24, 2020
@bors bors bot deleted the list-trivia branch September 24, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@robertylewis robertylewis robertylewis left review comments

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cipher1024 @semorrison @robertylewis @bryangingechen