Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*): cleanup imports, split off data/finset/preimage from data/set/finite #4221

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(*): cleanup imports, split off data/finset/preimage from data/set/finite #4221

wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

Mostly this consists of moving some content from data.set.finite to data.finset.preimage, in order to reduce imports in data.set.finite.

@semorrison semorrison marked this pull request as ready for review September 24, 2020 00:39
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Sep 24, 2020
@bryangingechen bryangingechen changed the title chore(*): cleanup imports chore(*): cleanup imports, split off data/finset/preimage from data/set/finite Sep 24, 2020
@bors
Copy link

bors bot commented Sep 24, 2020

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 24, 2020
@semorrison
Copy link
Collaborator Author

bors merge

@semorrison semorrison removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 24, 2020
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 24, 2020
bors bot pushed a commit that referenced this pull request Sep 24, 2020
@semorrison
chore(*): cleanup imports, split off data/finset/preimage from data/s…
5e934cd 
…et/finite (#4221)

Mostly this consists of moving some content from `data.set.finite` to `data.finset.preimage`, in order to reduce imports in `data.set.finite`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 24, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): cleanup imports, split off data/finset/preimage from data/set/finite [Merged by Bors] - chore(*): cleanup imports, split off data/finset/preimage from data/set/finite Sep 24, 2020
@bors bors bot closed this Sep 24, 2020
@bors bors bot deleted the imports branch September 24, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @bryangingechen