Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/witt_vector/witt_polynomial): definition and basic properties #4236

Closed
wants to merge 6 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Sep 24, 2020

From the Witt vector project

This is the first of a dozen of files on Witt vectors. This file contains
the definition of the so-called Witt polynomials.

Follow-up PRs will contain:

  • An important structural result on the Witt polynomials
  • The definition of the ring of Witt vectors (including the ring structure)
  • Several common operations on Witt vectors
  • Identities between thes operations
  • A comparison isomorphism between the ring of Witt vectors over F_p and
    the ring of p-adic integers Z_p.

Co-Authored-By: Rob Y. Lewis rob.y.lewis@gmail.com


Blocked by: #4197

@jcommelin jcommelin added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Sep 24, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 24, 2020
…roperties

From the Witt vector project

This is the first of a dozen of files on Witt vectors.
This file contains the definition of the so-called Witt polynomials.

Follow-up PRs will contain:

* An important structural result on the Witt polynomials
* The definition of the ring of Witt vectors (including the ring structure)
* Several common operations on Witt vectors
* Identities between thes operations
* A comparison isomorphism between the ring of Witt vectors over F_p and
  the ring of p-adic integers Z_p.

Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 24, 2020
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ready to merge when expand gets merged.

src/algebra/invertible.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/witt_polynomial.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/witt_polynomial.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/witt_polynomial.lean Outdated Show resolved Hide resolved
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 25, 2020
@jcommelin jcommelin changed the title feat(ring_theory/witt_vector/witt_polynomial): definition and basic properties (deps: #4197) feat(ring_theory/witt_vector/witt_polynomial): definition and basic properties Sep 25, 2020
@jcommelin jcommelin removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 25, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 25, 2020
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 25, 2020
@bors
Copy link

bors bot commented Sep 25, 2020

Canceled.

@Vierkantor
Copy link
Collaborator

bors merge

bors bot pushed a commit that referenced this pull request Sep 25, 2020
…roperties (#4236)

From the Witt vector project

This is the first of a dozen of files on Witt vectors. This file contains
the definition of the so-called Witt polynomials.

Follow-up PRs will contain:

* An important structural result on the Witt polynomials
* The definition of the ring of Witt vectors (including the ring structure)
* Several common operations on Witt vectors
* Identities between thes operations
* A comparison isomorphism between the ring of Witt vectors over F_p and
the ring of p-adic integers Z_p.

Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Sep 25, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/witt_vector/witt_polynomial): definition and basic properties [Merged by Bors] - feat(ring_theory/witt_vector/witt_polynomial): definition and basic properties Sep 25, 2020
@bors bors bot closed this Sep 25, 2020
@bors bors bot deleted the witt-poly branch September 25, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants