[Merged by Bors] - fix(tactic/lint/simp): only head-beta reduce, don't whnf #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Sep 24, 2020
|
|
||
|
|
||
| -- However injectivity lemmas can still be marked simp, | ||
| -- even though injective is reducible and unfolds to a bad simp lemma: |
There was a problem hiding this comment.
What do you mean by "bad" here?
There was a problem hiding this comment.
Bad in the sense of the simp_var_head linter (which this file tests). If you unfold injective f, then you get ∀ x y, f x = f y → x = y where the left-hand side x is a variable. This is bad because the simplifier code doesn't support this, and the linter makes sure we don't mark it as a simp lemma.
This lemma can never fire anyhow because of the `a ∈ s` condition, where `a` does not occur on the lhs.
gebner
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2020
This is necessary to accept simp lemmas like `injective reverse`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to accept simp lemmas like
injective reverse.See #4222 for motivation.
I don't know if this will break anything.